fix(opencode): flush stdio before cli exit#29340
Closed
YOMXXX wants to merge 1 commit into
Closed
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR Found:
The current PR (29340) is a broader fix that addresses the root cause for multiple commands by implementing a general stdio flushing mechanism before CLI exit, whereas PR #26389 may be a more targeted fix for the |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29330
Closes #26399
Type of change
What does this PR do?
The CLI explicitly calls
process.exit()after command handling to avoid hanging subprocesses. Large stdout writes can still be buffered at that point when output is piped, so commands such asopencode export <id> | jqoropencode debug skill | jqcan see truncated JSON.This PR adds a small stdio flush helper and waits for stdout/stderr write callbacks before the final forced exit. The explicit exit behavior is preserved, but pending buffered CLI output gets a chance to drain first.
How did you verify your code works?
cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/cli/stdout.test.tscd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun typecheckgit diff --checkPATH="$HOME/.bun/bin:$PATH" .husky/pre-pushScreenshots / recordings
Not applicable; CLI stdout flushing only.
Checklist